-
Notifications
You must be signed in to change notification settings - Fork 2
Update ufs-bundle to be buildable using entirely public repositories #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mark-a-potts
wants to merge
21
commits into
develop
Choose a base branch
from
feature/public
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/soca
…ndle into feature/public
4 tasks
climbfuji
reviewed
Feb 6, 2025
Collaborator
climbfuji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add something to the PR description about the purpose of the patch that is being applied, please?
Collaborator
Author
|
Thanks @climbfuji. I added in a brief description of the patch, which is used to handle the ensemble interface between JEDI and UFS. |
bcf5c30 to
feed812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates ufs-bundle so that it can be built using entirely public repos, which will allow it to be used in other software such as the global-workflow. The patch file included here is applied to the ufs-weather-model source code that is pulled from https://github.com/ufs-community/ufs-weather-model and modifies it so that ensemble forecasts can be run and properly controlled/accessed from JEDI, which is using FMS's ensemble manager.
List the other PRs that this PR is dependent on:
Checklist